
Theme style management (folder structure) should be more intuitive (folder names)
Reported by dleffler | August 13th, 2011 @ 07:04 PM | in 2.0.1 (closed)
By having the different theme styles (variations) in a folder named css_xxx, it implies that only the css files would be there. Recommend it be renamed to style_xxx and the 3 lines in the manage_themes method of the administration controller be changed from 'css' to 'style' this would also be in line with the convention that the 'backup' folder is names 'styles_backup'.
Furthermore, (in the switch_themes method) we should probably check for the existence of, then create the 'styles_backup' folder and 'css' & 'images' folder if they don't exist instead of asking the user to do it.
Comments and changes to this ticket
-
dleffler August 26th, 2011 @ 04:03 PM
- Milestone changed from Stable to 2.0.1
- Milestone order changed from 3 to 0
-
dleffler September 2nd, 2011 @ 11:55 AM
We're likely moving to a new concept for theme variations. I've already added a 'theme configuration' extension to the theme manager which can easily be adapted to any theme by extending the theme class and adding a $user_configured=true; property. The theme variables could simply be placed in the theme's config.php file as defines, OR a designer could write something more elaborate to 'configure' that theme.
-
dleffler September 9th, 2011 @ 07:15 PM
- State changed from new to resolved
This issue is resolved with the latest code in the develop branch which changes the way theme style variations are handled.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.