#699 ✓resolved

Feature request - Upgrade to CKEditor 4.x - inline editing?

Reported by dleffler | August 27th, 2012 @ 05:40 PM | in 2.1.1 (closed)

The CKEditor v4.x beta is now out. It includes a new inline editing for html 5 which is really neat http://nightly-v4.ckeditor.com/3427/samples/inlineall.html

Obviously, we'd want to upgrade to it as is, but we would probably wnat to best implement these new features also.

Comments and changes to this ticket

  • dleffler

    dleffler August 28th, 2012 @ 12:25 AM

    • Milestone set to 2.1.0
    • Milestone order changed from “199” to “0”

    FWIW, locally, v4.x beta works easily as a drop in replacement.

  • dleffler
  • dleffler

    dleffler November 26th, 2012 @ 12:19 PM

    As a note, there doesn't appear to be a method to save the edited inline text (when you move out of that box), but this may become more apparent upon the release of 4.x

  • dleffler

    dleffler December 3rd, 2012 @ 10:48 PM

    • Milestone set to 2.1.1
    • Milestone order changed from “13” to “0”

    FWIW v4.0 has been released, but doesn't seem to contain all the files needed to keep it from crashing unless we dump in the entire develop build. We'l need to determine which files are missing from a full/standard ckeditor package to keep from adding megabytes to our package size. The current default theme 'kama' though still available is no longer the default, we also have a couple of plugins which are no longer included in the regular packages such as stylesheetparser. This is further complicated by the fact that the new ckeditor package building doesn't produce a package with the requested plugins as expected.

  • dleffler

    dleffler December 13th, 2012 @ 04:04 PM

    As a note, v4.0 seems to still have a few issues. We will likely need to wait until the next release. I'm having difficulty with getting a good small package by the 'Builder' and autogrow seems to always be turned on. Additionally, some of the buttons don't seem to yet be fully functional.

    We may also need an upgrade script to reset the 'skin' to an existing one since the editor will crash if the selected skin is missing.

  • dleffler

    dleffler January 2nd, 2013 @ 09:01 AM

    • Title changed from “Feature request - Upgrade to CKEditor 4.x” to “Feature request - Upgrade to CKEditor 4.x - inline editing?”
    • Assigned user set to “dleffler”

    I have a local system running a new 'inline' text module template/view which allows you to edit the text item body and/or title and will save the changes when you leave the item. Here are some concerns:

    • ckeditor4 is still missing some needed ckeditor3 features and has other quirks as listed above, esp as an overall swap out for ckeditor3
    • should we provide user feedback on the changes?
    • should we provide user opt-out on the changes? It might be difficult/complex to revert to the original text...could possibly send back the original data via ajax reply if cancelled, but I'm not familiar with working with ajax returned data.
    • might be nice to have a tiny button to add/remove the item title via ajax
    • might be nice to have a tiny button to add/remove an item via ajax?
  • dleffler

    dleffler January 2nd, 2013 @ 09:05 AM

    FWIW, logically, it seems the best/only use for inline editing would be for text modules as most module items require more properties than just a couple text fields.

  • dleffler

    dleffler January 2nd, 2013 @ 11:48 AM

    Perhaps we might also use it to quickly edit module titles and descriptions?

  • dleffler

    dleffler January 2nd, 2013 @ 10:10 PM

    As a progress report, the inline template for the text module now fully supports inline editing of the item title and body, inline/ajax adding and deleting of text items, dynamic updating of the ddRerank dialog for sorting. Still needed:

    • option to cancel/revert changes when moving away from edited area
    • implement a 'save' button?
    • add/delete item title from opposite state...e.g., we can delete the title by deleting its contents and moving away (which updates the database object), but the display still shows an empty title line
    • implement viewer security/permissions so only editors have access, not a general user, NOR in preview mode
    • delete the ckeditor instance when deleting a text item
    • develop a good visual indicator for editable areas...currently using permanent dotted border and experiments w/ hover tend to flicker, background changes don't give wysiwyg, etc...

    In time, this may become the default showall view instead of showall_inline. Also ckeditor must be installed/shipped before this will work

  • dleffler

    dleffler January 2nd, 2013 @ 10:56 PM

    Probably should also mention that although there is progress in regards to inline editing, we've still not begun to 'tweak/customize' the editor to ensure the best use of buttons, addins, etc...

  • dleffler

    dleffler January 3rd, 2013 @ 05:30 AM

    Another update on the local experiment...functionally, it's all working in the text module except for the 'viewer security/permissions' part which we'll work on next. Have placed some of the editor tweaks in the template. FWIW, ckeditor v4 is STABLE, but haven't established a 'good' package or custumization to the point of shipping. NExt steps:

    • add option to turn off/on the save/revert question for enhanced safety or speed, btw revert is implemented
    • add code to turn off the editing when the user doesn't have permissions to edit or in preview mode.
    • implement a 'save' button to save without leaving the edit area (NOT a priority at this point)
  • dleffler

    dleffler January 3rd, 2013 @ 04:15 PM

    update -- now have the save/revert optional fast-save integrated (use jqueryui 3-button dialog), also the permissions/preview detection.

    As a note...Titles are always 'changed' since they are wrapped in

    in the editor. This is only an issue as every time focus leaves a title, it'll be found 'dirty' and the 'save' process begins with optional prompt. Not sure it's worth all the code to set up different editors for the title and body...fwiw, we edit the title BETWEEN the h2 tags.

  • dleffler

    dleffler January 10th, 2013 @ 11:32 PM

    As a note v4.0.1 has been released (v3.6.6 was released a few days ago also)

  • dleffler

    dleffler January 11th, 2013 @ 07:05 PM

    fwiw, 4.0.1 seems to better adhere to the config passed in the inline edit view...likely to be pushed up soon...

  • dleffler

    dleffler January 11th, 2013 @ 07:11 PM

    Ok, I've now gotten the toolbar config to work (or they did) and the skin...still need to create a minimal toolbar for the title (text only) and a decent toolbar (not overly complex for the other...or may rely on the toolbar configuration.

  • dleffler

    dleffler January 11th, 2013 @ 07:50 PM

    Ok, the toolbars & settings (for the most part) are done, now we just need an upgrade script to make sure we don't break do to a bad toolbar name.

  • expNinja

    expNinja January 11th, 2013 @ 08:18 PM

    • State changed from “new” to “resolved”

    (from [2feddaaa8dfc12e365a2439784faba30b95b8838]) Adds new 'inline' view to text module to allow editing directly on the page (titles & body and add & remove text items) via an upgrade to CKEditor 4.x [#699 state:resolved] https://github.com/exponentcms/exponent-cms/commit/2feddaaa8dfc12e3...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Bug Tracker for Exponent CMS

Shared Ticket Bins

People watching this ticket