
Upgrade: Migrate core modules to controllers
Reported by dleffler | April 29th, 2011 @ 03:16 PM | in 2.2.0alpha2 (closed)
Container & Common modules need to be upgraded from old school (1.0) to 2.0 controller or deprecated.
- Complete initial implementation
- Handle website upgrades from earlier version with 1.0 files
Comments and changes to this ticket
-
dleffler August 1st, 2011 @ 08:00 PM
- Assigned user set to expNinja
- Complete the initial implementation
- Also handle website upgrades from earlier version with 1.0 files/tables (upgrade script)
-
dleffler August 1st, 2011 @ 08:01 PM
- Assigned user cleared.
-
dleffler September 24th, 2011 @ 09:12 PM
- Title changed from Upgrade/Deprecate core modules to controllers to Upgrade: Migrate core modules to controllers
-
-
dleffler October 26th, 2012 @ 04:54 PM
This would also include importer/exporter
- containermodule
- commmon (not really a module, but actions/views)
- exporter
- importer
-
dleffler November 21st, 2012 @ 08:56 PM
- Milestone changed from 2.1.0 to 2.1.1
- Milestone order changed from 5 to 0
-
dleffler January 19th, 2013 @ 05:03 AM
- Assigned user set to dleffler
We'll go ahead and knock out the common actions/views...
- configure, saveconfig, & show_view (calendarmodule) are only for old school modules
- user & group perms would best fit in the userController.
That would only leave these old school modules (modules-1)
- containermodule (the most complex upgrade)
- importer & exporter into the importexportController?
-
expNinja January 19th, 2013 @ 03:01 PM
(from [2a717612185d035e3099d8b72c37450ac2c4ebfc]) Migrates common old school modules to controllers (perms to user controller and config/show_view only apply to old school modules), also makes more consistent use of expCore::makeLocation [#144] https://github.com/exponentcms/exponent-cms/commit/2a717612185d035e...
-
expNinja January 19th, 2013 @ 03:20 PM
(from [83eab056c981917412a2eb1bee6dc37c531594a3]) Adds missing files and Removes fully deprecated old modules, calendarmodule and common actions/views (except configure which is still used by containermodule) [#144] https://github.com/exponentcms/exponent-cms/commit/83eab056c9819174...
-
dleffler January 19th, 2013 @ 04:08 PM
Looks like it might be best to migrate the containermodule to containerController in the modules/container folder. Import/Export may actually be more difficult since the importexportController is not very clean right now.
We'll go ahead and merge ticket #704 into here, Feature request - Move core controllers in to modules/core. This would move all core controllers with views into the modules/core folder for greater consistency
-
dleffler January 19th, 2013 @ 10:39 PM
Looks like it might be best to migrate the containermodule to containerController. Import/Export may actually be more difficult since the importexportController is not very clean right now.
Though I have a preliminary containerController running locally, we'll probably also want/need to scrub everything else to move to a single style/type of location_data where we refer to the module by its name sans the 'Controller' suffix. We find them stored here:
- container
- sectionref
- grouppermission/userpermission
-
dleffler January 23rd, 2013 @ 01:28 AM
Also modstate uses long/class names
- container->internal & container->external
- container->module, container->is_existing, & container->is_private are deprecated, with container->view_data only for old school modules
- modstate->module
- sectionref->module
- grouppermission->module & userpermission->module
- container->internal & container->external
-
dleffler January 23rd, 2013 @ 03:05 AM
Note: This is the most complicated upgrade conversion I've done yet! Containers are interwoven throughout many subsystems and smarty plugins... However, there seems to be light at the end of the tunnel!
Currently have a local test running with basic modules & embedded containers working. There's still a lot of work as I've had to hard-code/convert all controller names to the full class name (for now)
Still much work to do...
-
dleffler January 23rd, 2013 @ 03:02 PM
Additional table notes:
- sectionref->is_original is deprecated
One of the reasons Container is difficult to upgrade to 2.0 is that most other modules simply interact with other 2.0 or MVC modules, whereas, the Container module has both old school and MVC modules 'running' through it. Not only this, but it's heavily tied to the expTheme & expPermissions subsystems. And I've had to create a few more expModules subsystem helper methods to deal with getting us the correct 'name' of module 'items' such as the proper class name of the actual controller vs the common name of the module, etc...
-
dleffler January 24th, 2013 @ 07:13 PM
- Tag changed from common, containers to common containers
I now have a fairly complete implementation of container 2.0
includes permissions, etc. The following have not yet been integrated, and may wait until after the initial cimmit- access to configure, which just means we don't have a ui yet
- migration updated to account for any of these changes
- content module link selection, from the popup window when embedding a link in the editor
-
expNinja January 25th, 2013 @ 01:20 AM
(from [db1b4f0eb9aa479266800362d4915a0152697183]) Initial integration of container 2.0 in container2 feature branch (feature/container2) [#144] https://github.com/exponentcms/exponent-cms/commit/db1b4f0eb9aa4792...
-
expNinja January 25th, 2013 @ 05:17 AM
(from [4fb6861709c4c12d95bb91743683d190ee325ef2]) Missing files for container 2.0 in container2 feature branch (feature/container2) [#144] https://github.com/exponentcms/exponent-cms/commit/4fb6861709c4c12d...
-
expNinja January 25th, 2013 @ 05:19 AM
(from [8c82cc18aa56c027956e8724f6e692c120476b9e]) Changes format for 'required' mark on controls [#144] https://github.com/exponentcms/exponent-cms/commit/8c82cc18aa56c027...
-
-
expNinja January 25th, 2013 @ 05:55 PM
(from [f6ad241ef73fb02dd86df2c1461cc61bb53db7ef]) Fixes sectionref upgrade problem w/ container2 [#144] https://github.com/exponentcms/exponent-cms/commit/f6ad241ef73fb02d...
-
expNinja January 26th, 2013 @ 12:19 AM
(from [e55d093678d347a2ac069662c29145c77903a598]) Files needed for container2 to work [#144] https://github.com/exponentcms/exponent-cms/commit/e55d093678d347a2...
-
dleffler January 27th, 2013 @ 12:14 AM
Final step will be to determine how to 'move' inporter/exporter.
-
dleffler January 27th, 2013 @ 02:24 AM
- State changed from open to resolved
Creating new ticket #887 to hold the final upgrade of importer/exporter
-
dleffler February 15th, 2013 @ 05:32 PM
- Tag changed from common containers to containers
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Bug Tracker for Exponent CMS
Tags
Referenced by
-
704 Feature request - Move core controllers in to modules/core We'll merge this with ticket #144 Upgrade: Migrate core m...
-
887 Feature request - Upgrade importer/exporter to 2.0 New ticket opened to close ticket #144