#1412 ✓resolved
Peter

IE10+ Compatibility

Reported by Peter | May 6th, 2017 @ 08:56 AM | in 2.4.2 (closed)

Whilst fixing a css formatting bug in IE11, I notice that you have in the loaded page source code a couple of workaround statements that do not work in IE10+:

<!--[if IE 10]><link rel="stylesheet" href="/external/ie10-viewport-bug-workaround.css" type="text/css"><![endif]--> <!--[if IE 10]><script src="/external/ie10-viewport-bug-workaround.js"></script><![endif]--> <!--[if IE]> <link href='/themes/sandtofttheme/css/ie_fixes/ie_fixes.css' rel="stylesheet" type="text/css" /> <![endif]-->

As I understand it, the 'if' statements are no longer supported and so these lines do not load. I have used @media in my CSS for my workaround. It may be you have the workaround elsewhere, but I thought I'd better mention it.

Peter.

Comments and changes to this ticket

  • dleffler

    dleffler May 6th, 2017 @ 07:33 PM

    • State changed from “new” to “open”
    • Assigned user changed from “expNinja” to “dleffler”
    • Milestone set to 2.4.2

    They should NOT be loading, as those fixes aren't needed in newer versions of IE. The only apply to IE 10 under Windows 8? http://getbootstrap.com/getting-started/#support-ie10-width

  • Peter

    Peter May 7th, 2017 @ 08:17 AM

    Hi Dave. Yes, but my understanding was that <!--[if IE 10]> is ignored by IE10+ so the statement doesn't do anything.

    The specific problem that I have is the positioning of "leftcol" (which is in fact the right column on the web site). On all non-ie browsers the positioning is controlled by:

    #leftcol{ margin-left: 745px; }

    In IE11 there was no sign of the left column. To fix this I needed:

    @media screen and (-ms-high-contrast: active), screen and (-ms-high-contrast: none) {
    /* IE10+ specific styles go here */ #leftcol { margin-left: 7px; } }

    Also Edge did the disappearing act too, but had to be fixed with:

    @supports (-ms-ime-align:auto) { .selector { property:value; } }

  • dleffler

    dleffler May 8th, 2017 @ 01:58 AM

    You are probably correct...for the next patch/release, we'll remove the 'if' statements...I've also updated the .css and .js code to more recent flavors.

    It's unlikely we'd imcorporate the IE11/Edge fixes since they seem like more of a custom approach and may interfere with some theme style approaches?

  • Peter

    Peter May 8th, 2017 @ 08:22 AM

    I just wish the browser developers would stop delivering big bags of worms... The ultimate challenge became Chrome vs. Safari. Both use the same engine so a fix for one fixes the other. Except one needed the big margin and one the small margin. In the end I gave up on fixing the leftcol and floated it instead, thus negating the need for the other fixes.

    I suppose you could consider putting the IE10+ statement at the end of 0-basestyles without any actual modified tags, suitably commented that the developer can add custom tags here if needed. The Edge fix just seemed to work. You could also add it but commented out, so at least saving people time looking for how to fix a problem.

    Thanks again for your help with my problems.

    Peter.

  • dleffler

    dleffler July 26th, 2017 @ 03:51 PM

    • State changed from “open” to “resolved”

    Fix included in next patch

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Bug Tracker for Exponent CMS

Shared Ticket Bins

People watching this ticket

Attachments

Pages