Bug: ddrerank logic is flawed
Reported by dleffler | May 3rd, 2013 @ 12:05 AM
There are some logic issues within ddrerank which don't always work as expected...some of this is a regression bug with adding the ordering of containers, form controls, and categories, but may have existed earlier.
This seems to have been complicated or brought to light when fixing the 'uniqueid' issue and getting the rerank id to be assigned properly for list of modules and items on a page (there may be a 'panel/link' combo for each container (with more than one module) and each module (with more than one manually sorted item) on a page.
Need to 'square away' which params should be 'obeyed', esp. since we've never accounted for aggregation and are only passed a page's worth of items. Current params are:
- items - list of items
- model - basic model for list of items
- where - where statement applied to model, used in design_forms
- sql - pull items by sql statement
- module - needed to assist w/ container and category ordering?
- only - used to limit list, esp w/ categories, may be redundant for where, used in help
- uniquieid - probably deprecated since we fixed the 'loc' not being passed to templates issue
- id - to discriminate uniqueid based on $loc and 'id' to place in form hidden field
- controller - used to override 'loc->mod' for controller to call 'manage_ranks' method
- label - label for window title
- sortfield - the 'field' to display in the list if not 'title'
In majority of usage, only the items, model, & label params are passed
Comments and changes to this ticket
-
dleffler June 1st, 2013 @ 07:34 PM
- Milestone set to “2.2.1”
-
dleffler July 11th, 2013 @ 07:47 PM
So the BIG question is how much should ddreorder, reorder when 'items' are passed?
- only those items passed
- only those items within the current module
- those items aggregated into the current module
of course a 'sql' would be examined 'as is'
passing a 'module' implies we get ALL module items unless a 'where' and/or 'only' is passed...this works mainly for getting all categories, etc...
-
dleffler July 17th, 2013 @ 10:46 AM
As a note, we currently get all the items in the module, but NO aggregated items, so in essence the function is working, but may not be working as intended?
-
-
-
-
-
-
-
-
-
-
-
-
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Bug Tracker for Exponent CMS
dleffler
expNinja
Tags
Referenced by
-
1004
Bugs in Media Player Module
reorder bug is ticket #1001 and actually has been present...