#1001 new
dleffler

Bug: ddrerank logic is flawed

Reported by dleffler | May 3rd, 2013 @ 12:05 AM | in 2.3.7 (closed)

There are some logic issues within ddrerank which don't always work as expected...some of this is a regression bug with adding the ordering of containers, form controls, and categories, but may have existed earlier.

This seems to have been complicated or brought to light when fixing the 'uniqueid' issue and getting the rerank id to be assigned properly for list of modules and items on a page (there may be a 'panel/link' combo for each container (with more than one module) and each module (with more than one manually sorted item) on a page.

Need to 'square away' which params should be 'obeyed', esp. since we've never accounted for aggregation and are only passed a page's worth of items. Current params are:

  • items - list of items
  • model - basic model for list of items
  • where - where statement applied to model, used in design_forms
  • sql - pull items by sql statement
  • module - needed to assist w/ container and category ordering?
  • only - used to limit list, esp w/ categories, may be redundant for where, used in help
  • uniquieid - probably deprecated since we fixed the 'loc' not being passed to templates issue
  • id - to discriminate uniqueid based on $loc and 'id' to place in form hidden field
  • controller - used to override 'loc->mod' for controller to call 'manage_ranks' method
  • label - label for window title
  • sortfield - the 'field' to display in the list if not 'title'

In majority of usage, only the items, model, & label params are passed

Comments and changes to this ticket

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Bug Tracker for Exponent CMS

Shared Ticket Bins

People watching this ticket

Tags

Pages