Bug: minify crashes when attempting to load a script more than once
Reported by dleffler | January 22nd, 2013 @ 04:40 PM | in 2.2.1 (closed)
If we attempt to load the same script (local?) when minify is turned on, it'll crash the page.
The solution is to give a universal 'unique' identifier to each script so it's only loaded once per page. This MAY require breaking out the 'src' of a {script} block separate from the content code.
e.g., the flowplayer script has the unique id of 'flowplayer'
Comments and changes to this ticket
-
-
dleffler January 25th, 2013 @ 03:21 PM
- Milestone changed from “2.1.2” to “2.1.1”
-
-
-
dleffler February 16th, 2013 @ 02:55 AM
- Milestone changed from “2.2.0alpha2” to “2.2.0alpha3”
-
dleffler March 2nd, 2013 @ 09:45 PM
- Milestone changed from “2.2.0alpha3” to “2.2.0beta1”
-
dleffler March 16th, 2013 @ 03:27 AM
- Milestone changed from “2.2.0beta1” to “2.2.0beta2”
-
dleffler March 29th, 2013 @ 07:59 PM
- Milestone changed from “2.2.0beta2” to “2.2.0beta3”
-
dleffler April 20th, 2013 @ 10:17 AM
- Milestone changed from “2.2.0beta3” to “2.2.0release-candidate”
-
dleffler May 1st, 2013 @ 10:22 AM
- Milestone changed from “2.2.0release-candidate” to “2.2.1”
-
-
dleffler May 31st, 2013 @ 01:26 PM
- Tag changed from “javascript, minify” to “javascript minify”
- Assigned user set to “dleffler”
- Milestone set to “2.2.1”
We should clean the array of script src's before parsing them out.
-
expNinja May 31st, 2013 @ 06:37 PM
- State changed from “new” to “resolved”
(from [1b03b8f00c56d884136a31be95b03ce031069076]) Scrubs javascript array for duplicates prior to processing since it'll crash minify. [#872 state:resolved responsible:dleffler] https://github.com/exponentcms/exponent-cms/commit/1b03b8f00c56d884...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Bug Tracker for Exponent CMS
dleffler
expNinja