Exponentcms Exponent CMS → 2.0.3

Hi, guys.

(I need to double-check this behaviour, upgrading my dev. machine at the moment.)

2.02 installed, all going nicely. My page sitting in Firefox.

I upgrade MySQL 5.1.59 to 5.1.60 - as part of the upgrade, MySQL stops.

Idle curiosity - what happens to Exponent? Refresh my page - various messages about cannot connect, etc. as expected ... but ...

Exponent CMS
Upgrade
Simple Site Upgrade

Since your website has a configuration file already in place, we're going to perform a couple simple tasks to ensure you're up and running in no time.

Next, we'll Install Tables, and then run through any upgrade scripts needed to bring your code and database up to date.
Continue to Install Tables

What??? Not a good look, so I quickly started MySQL ...

But - Exponent still wants me to go through the installer - it has gone and created a NEW install/not_configured file, so from now on it will go round this loop.

Why?

index.php

 88         // check to see if we need to install or upgrade the system
 89         expVersion::checkVersion();

framework/core/subsystems/expVersion.php

     48         /**
     49          * Routine to check for installation or upgrade
     50          */
     51         static function checkVersion() {
     52                 global $db;
     53
     54                 // we're not up and running yet, so fix that first
     55                 if (@file_exists(BASE.'install/not_configured') || !(@file_exists(BASE.'conf/config.php'))) {
     56                         self::launchInstaller();
     57                 }

First time through (when MySQL down) - neither of those conditions true, so launcher not installed here ...

     58
     59                 // version checking routine, check database version against software version
     60                 $dbversion = $db->selectObject('version',1);
     61                 if (empty($dbversion)) {
     62                         $dbversion->major = 0;
     63                         $dbversion->minor = 0;
     64                         $dbversion->revision = 0;
     65                         $dbversion->type = '';
     66                         $dbversion->iteration = '';
     67                 }

MySQL down - so I'm guessing $dbversion will be empty - so we say version major is 0.

     68                 if ($dbversion->major < EXPONENT_VERSION_MAJOR) {
     69                         self::launchInstaller();

0 is < 2, so let's launch the installer ...

And what does the installer do?

     90         static function launchInstaller() {
     91                 // we'll need the not_configured file
     92                 if (!@file_exists(BASE.'install/not_configured')) {
     93                         $nc_file = fopen(BASE.'install/not_configured', "w");
     94                         fclose($nc_file);

So, even when I restart MySQL - the launcher has created install/not_configured.

So now I'm stuck in the run install loop. Next page refresh hits line 54 - which now finds the not_configured file.

So imagine you are upgrading MySQL on a server (or MySQL is down for whatever other reason, or runs out of connections, etc.) A web visitor (human or spider) hits the page when MySQL stopping/down. Can't do version check, so it creates the not_configured file. Your next visitor after MySQL is restarted is going to be in the installer.

(Don't have a fix for this at present, as above - I'm upgrading my development machine.)

Apologies in advance if a red herring - I definitely DID see something odd, and what I saw definitely seems possible from the code - once I get this machine upgraded I'll confirm.

Thanks.