#234 ✓resolved
dleffler

Consider consolidating several like files in the page load process

Reported by dleffler | July 14th, 2011 @ 07:09 PM | in Release Candidate 1 (closed)

In an effort to streamline the page load process to become more efficient and logical, we might want to:
* combine the exponent_common.php & exponent_bootstrap.php files calling them exponent_bootrap.php * move the loading of exponent_constants.php out of exponent.php and into exponent_bootstrap.php * move the loading of subsystems/themes.php out of exponent_constants.php and into exponent.php after sessions is loaded and initialized (current loading order is therefore maintained) * combine or streamline the files loaded by exponent_bootstrap.php; exponent_variables.php (which in turn loads) exponent_version.php and subsystems/config/load.php (which then in turn loads the global config, the theme config, then the default configs), exponent_setup.php and exponent_constants.php; since all establish the constants (defines) for exponent. (There has to be a more logical flow and grouping than current)

Comments and changes to this ticket

  • dleffler

    dleffler July 15th, 2011 @ 11:52 AM

    • Title changed from “Consider consolodating several like files in the page load process” to “Consider consolidating several like files in the page load process”
    • Assigned user set to “dleffler”
  • dleffler

    dleffler July 15th, 2011 @ 12:42 PM

    • combine the exponent_common.php & exponent_bootstrap.php files calling them exponent_bootstrap.php
      • exponent_common.php only creates the realpath() function and loads exponent_bootstrap.php which in turn attempts to create the realpath() function.
    • move the loading of exponent_constants.php out of exponent.php and into exponent_bootstrap.php
      • Since all these files simply set the "defines" of the environment
    • move the loading of subsystems/themes.php out of exponent_constants.php and into exponent.php after sessions is loaded and initialized (current loading order is therefore maintained)
      • again, to maintain a standardized approach to the loading sequence and flatten it somewhat
    • combine or streamline the files loaded by exponent_bootstrap.php: exponent_variables.php (which in turn loads) exponent_version.php and subsystems/config/load.php (which then in turn loads the global config, the theme config, then the default configs), exponent_setup.php and exponent_constants.php; since all establish the constants (defines) for exponent. (There has to be a more logical flow and grouping than current)
  • expNinja

    expNinja July 15th, 2011 @ 11:02 PM

    (from [9c51af40cdffb857ff0a9f49cd295545f4fa66ef]) Changed references to exponent_common.php to exponent_bootstrap.php since exponent_common was simple and also redundant of what was already in exponent_bootstrap.php. [#234] https://github.com/exponentcms/exponent-cms/commit/9c51af40cdffb857...

  • dleffler

    dleffler July 15th, 2011 @ 11:03 PM

    references to exponent_common.php has been replaced wtih exponent_bootstrap.php. If this doesn't cause any issues, we'll delete exponent_common.php

  • expNinja

    expNinja July 16th, 2011 @ 12:18 AM

    (from [dbfcc88ba9163ed736416b22bde0798d9a67ce64]) Loading of exponent_constants.php was moved earlier into exponent_bootstrap.php for standardization. Loading of subsystems/themes.php was stripped out of exponent_constants.php and put into exponent.php where is was being loaded earlier. [#234] https://github.com/exponentcms/exponent-cms/commit/dbfcc88ba9163ed7...

  • expNinja

    expNinja July 16th, 2011 @ 12:18 AM

    (from [c73b253790b4a49b8d240a483c821b0e88282fff]) A seemingly major change because of the filenames, but a Minor revision to the exponent "bootstrap" process to streamline it and give it a more linear flow. exponent_variables.php renamed to exponent_constants.php which was in turn renamed to exponent_constants2.php before it'll be deleted. Contents were moved into other file with config dependant constants being moved inot exponent_bootstrap.php
    exponent_setup.php was renamed to exponent_php_setup.php since that's it's function and the environment constants were moved into exponent_constants.php.
    [#234] https://github.com/exponentcms/exponent-cms/commit/c73b253790b4a49b...

  • dleffler

    dleffler July 16th, 2011 @ 12:24 AM

    At this point, if nothing seems to be broken, we can delete the exponent_constants2.php file.

    • I'll need to write an upgrade script for rc1 that deletes exponent_common.php, exponent_variables.php, exponent_setup.php (probably exponent_constants2.php), compat.php, the compat/ folder, captcha.php, & captcha_why.php since they've all become obsolete and are no longer referenced. Though their remaining in the folder does no harm.
    • Will likely want to delete the deps.php and exponent_compt.php files since they are derelicts from 1.0.
  • expNinja

    expNinja July 25th, 2011 @ 11:39 PM

    • Milestone set to Release Candidate 1
    • State changed from “new” to “resolved”
    • Milestone order changed from “71” to “0”

    (from [e7bbf799ccd2233027c37000f1b29475f556ad4e]) Removes some files no longer used in the "bootstrap" process [#234 state:resolved milestone:'Release Candidate 1'] https://github.com/exponentcms/exponent-cms/commit/e7bbf799ccd22330...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Bug Tracker for Exponent CMS

Shared Ticket Bins

People watching this ticket

Pages