#142 ✓resolved
dleffler

Upgrade navigation module to controller

Reported by dleffler | April 29th, 2011 @ 03:12 PM | in 2.0.9 (closed)

Navigation module needs to be upgraded from old school (1.0) to 2.0 controller.

  • Complete initial implementation
  • Handle website upgrades from earlier version with 1.0 files

Comments and changes to this ticket

  • dleffler

    dleffler July 30th, 2012 @ 07:14 PM

    Based on an irc conversation...

    • move static methods into a subsystem (expRouter or expCore?)
    • navigationController would be a 'menu' interface to global variables / section table, etc...
  • dleffler

    dleffler July 31st, 2012 @ 01:25 PM

    • Milestone changed from 2.1.0 to 2.0.9
    • Milestone order changed from “3” to “0”

    Make an attempt at beginning conversion in 2.0.9

    • static methods will likely REMAIN in navigationController UNLESS they are NOT navigation related.
  • dleffler

    dleffler August 1st, 2012 @ 03:30 AM

    • Assigned user set to “dleffler”
    • Milestone order changed from “1” to “0”

    Have the display portion working locally. Still need the following:

    • migration script
    • upgrade script
    • page management
    • compatibility layer (since most themes call the module, NOT the controller which also needs the 'action' parameter

    May also want to streamline the type/number of view templates now that we can have an expConfig, view configuration, etc... with each.

  • dleffler

    dleffler August 1st, 2012 @ 03:57 AM

    Actually, I think the emulation layer can be as simple as this:

    static function show($view,$loc = null,$title = '') {
        renderAction(array('controller'=>'navigation','action'=>'showall','view'=>'showall_'.$view));
    }
    return;
    

    Upgrade script would need to copy all theme custom /navigationmodule/views/xxx.tpl to /navigation/views/navigation/showall_xxx.tpl

  • dleffler

    dleffler August 4th, 2012 @ 12:50 AM

    Note to self...when we move to a navigation controller from a module, it'll play havoc with permissions and location_data since we are (sometimes) operating inside a controller the 'Controller' suffix isn't passed. I have seen this firsthand locally now that I have a version with all the class.php methods moved into the controller.

    May require going through all the code and 1) fixing all references to xxxController to be simply the name (xxx) and then 2) an upgrade script to scour an existing database and doing the same.

  • dleffler

    dleffler August 10th, 2012 @ 08:13 PM

    fwiw, I've circumvented the permissions/location_data issue.

    Still need an upgrade and migration script, otherwise, we are functional locally.

    Leaving the 'class.php' and 'assets' in modules-1 folder for compatibility layer.

  • dleffler

    dleffler August 11th, 2012 @ 02:52 AM

    The upgrade and migration scripts are complete and seems to be working locally, will test a few more days before pushing this up to develop branch.

  • dleffler

    dleffler August 15th, 2012 @ 12:12 AM

    • State changed from “open” to “resolved”

    This update has been pushed up, I'll close it to open new tickets on any issues encountered.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Bug Tracker for Exponent CMS

Shared Ticket Bins

People watching this ticket

Tags

Pages