Exponentcms Exponent CMS → 2.3.4

Comments and changes to this ticket

• 

  dleffler March 2nd, 2015 @ 02:31 PM

  • Title changed from “Improvement Suggestion” to “Feature request: Recycle Bin 'remove all' feature”
  • Tag set to “recycle bin”
• 

  dleffler March 2nd, 2015 @ 03:20 PM

  • Assigned user changed from “expNinja” to “dleffler”
  • Milestone set to “2.3.4”

  So a 'remove all' or 'empty recycle bin' feature would fit the bill? Adding a 'checkbox' to the screen might have some adverse side effects depending on which modules were being displayed.

• You flagged this item as spam.
  

  Peter March 2nd, 2015 @ 03:24 PM

  Yes it would! Thanks, just spent ages emptying it!

• 

  expNinja March 2nd, 2015 @ 05:44 PM

  • State changed from “new” to “resolved”

  (from [f67ec7faa43817fe3946381dd588444918978027]) Adds 'empty recycle bin' feature to recyclebin showall view; also fixes an error which could occur if attempting to delete a recycle bin item where the custom module is no longer installed [#1276 state:resolved] https://github.com/exponentcms/exponent-cms/commit/f67ec7faa43817fe...

• You flagged this item as spam.
  

  Peter March 3rd, 2015 @ 11:58 AM

  I've made the changes. Empty recycle bin option is there, when I click it, it asks for confirmation, then after processing the one item, a text module, that was in there is still there. Peter.

• 

  dleffler March 3rd, 2015 @ 02:11 PM

  You replace the recyclebin controller file, model file, and 'showall' view file? All had several changes to them. If you only added an 'icon' line with 'remove_all' to the view, it would attempt to run the old 'remove' (single itme) method.

  I had written a new remove_all() method to the controller, cleaned up the model by moving some code from the controller to it, and then the easy part, added a 'icon' line to the showall view to call the new controller method. Plus now 'remove()' and 'remove_all()' provide some feedback in the form of a message when completed.

  This is in the pre-release 2.3.4 code since 2.3.3 was already closed and released.

• You flagged this item as spam.
  

  Peter March 3rd, 2015 @ 04:26 PM

  Yes, updated and replaced all three. There was no message after processing either. I have double checked the changes are OK.

  One question - in the browser on two lines there was a darker green oblong which after copy / paste renders as a space. Is this correct?

  Peter.

  • Capture.JPG 35.2 KB
  • Capture1.JPG 43.3 KB
• 

  dleffler March 3rd, 2015 @ 06:46 PM

  It works as expected locally. By the 'green oblong' you are referring to the attached images? Yes, I try to reformat the code to PSR-0,4 coding standards whenever I change it. In the case of the screenshots, it simply added a space to the 'define' statements.

  If you are not getting a 'flash' message after performing a Recycle Bin Emptied you probably don't have all the new code. Because the message is always displayed regardless of if it was able to remove modules or not. (there is some code to prevent the page crashing if there is something in the recycle bin from a non-existent module).

• You flagged this item as spam.
  

  Peter March 4th, 2015 @ 09:33 AM

  Yes, that's what I meant. Here are two screen shots - the first is the recycle bin, the second after clicking to Empty. Then after processing the screen blanks momentarily and it just goes back to the same as the first capture. I have rechecked all three files and uploaded again.

  This is not urgent now, as I have otherwise emptied the bin and have launched the site. Hopefully there will be minimal changes now for a little while until I'm sure the site has settled down and working to everyone's satisfaction. However if you do have any thoughts on why it doesn't work for me...

  • Capture.JPG 52 KB
  • Capture1.JPG 58.9 KB
• 

  dleffler March 4th, 2015 @ 01:05 PM

  OK, the screenshot explains it...the 'textmodule' is an old 1.x module (now called textController or simply text). Since the module does not exist, it can't be deleted because we can't call it's 'delete' methods. Not sure how it got in there, don't think we've ever had the 'textmodule' in any of the 2.0 code even going back to the initial preview release...or it's something that fell through the migration process from 0.9x.

• You flagged this item as spam.
  

  Peter March 4th, 2015 @ 01:10 PM

  The site was created from the start with Exponent 2, so no migration from my side. I just tried to delete the text module by itself, but that failed too! At least you know why this happened. Just need to find a way of deleting this module. Peter.