Comments and changes to this ticket
-
dleffler July 23rd, 2013 @ 07:51 PM
- Tag changed from “workflow” to “permissions, workflow”
Implement 'workflow' similar to that in 0.9x, which adds approval and history to module items.
In most cases this might be easily (sic) tied in through expRecord update/save methods if the module supports workflow
-
dleffler August 7th, 2013 @ 05:34 PM
- Title changed from “Feature request - Add 'workflow'” to “Feature request - Add 'revisions' and 'approval'”
This might be two separate things, but tied together. Initially, approval would be an approved/not approved state. Some ideas based on a telcon:
- revision_id field & expRecord->supports_revisions is already shoehorned in expRecord/expDatabase
- need to display old/unapproved revisions in 'place/context' which might best be handled by some sort of revision drop down. Would require some sort of 'marker' when NOT displaying the real/current revision.
- workflow would probably require an additional perm of 'approve_edit' and maybe 'approve_create' and 'approve_delete', etc... with one having those perms receiving auto-approval
-
dleffler September 15th, 2013 @ 12:05 AM
- Milestone set to “2.2.4”
Will likely require a new 'view' mode similar to 'preview' where the standard/normal view for one with 'approve' perms would see the most recent UN-approved item, but it would be highlighted as unapproved (yellow background with red border unless hover?) and the new 'normal' view mode would display the most current approved items, and the 'preview' mode would remove the chrome, etc... as it does today.
Would require an 'approve' button/link or something to easily approve the displayed un-approved item.
Would require a way to display the desired revision in context (pass via session variable?) e.g., v2 is most recent approved, v3 is most recent unapproved, but I want to see v1 in context. Again, this may be best selected by some sort of dropdown type list of revisions with some sort of summary context?
Most likely a single (global via expController.php) perm of 'approve' would work if you have the 'approve' perm (e.g., manage = all perms), the update would be auto-approved.
-
dleffler September 15th, 2013 @ 01:15 AM
In order for the 'revision_id' to work, we must add it to the table as a Primary Composite Key along with the other keys (normally 'id')
Requires activating the 'PRIMARY KEY' code of the db engine alterTable() method.
-
dleffler November 2nd, 2013 @ 03:57 PM
- Assigned user set to “dleffler”
-
dleffler November 4th, 2013 @ 12:11 PM
As a note, we have the 'composite primary key' code already working in the v2.2.3 release.
-
dleffler November 5th, 2013 @ 10:01 PM
As a follow-up note, the composite primary key code in 2.2.3 is NOT working, but is working locally...soon to be added to develop for 2.2.4 or possibly the next 2.2.3 patch. Also have most of the code working for revisions sans a user interface to actually change things outside of the direct database table editing.
-
expNinja November 22nd, 2013 @ 07:32 PM
(from [5c58259381e5d37720305d835dbbf3d43c1ef478]) Add revisions and approval to text module [#1058] https://github.com/exponentcms/exponent-cms/commit/5c58259381e5d377...
-
expNinja November 22nd, 2013 @ 07:44 PM
(from [13f24e7b78cf4264098d385c08a354d2ed9ead77]) Shouldn't display revision number if there is only one revision (original) [#1058] https://github.com/exponentcms/exponent-cms/commit/13f24e7b78cf4264...
-
dleffler November 26th, 2013 @ 12:04 PM
There is an initial implementation of revisions in the 'revisions' branch of the github repo. It is only enabled in the Text module and only in the showall view. You MUST UPDATE the database tables to add the appropriate fields needed for revisions to work.
-
expNinja December 26th, 2013 @ 03:34 AM
(from [b01f65b74c594f168cf7e1476fdd29a58960c82c]) Adds 'approval' feature (currently only text showall action/view) [#1058] https://github.com/exponentcms/exponent-cms/commit/b01f65b74c594f16...
-
expNinja December 26th, 2013 @ 03:34 AM
(from [3cf2b2520ded067d2c9adc5104dd44bdd51078c6]) Fixes 'Preview mode' to account for un-approved items by only displaying approved revisions [#1058] https://github.com/exponentcms/exponent-cms/commit/3cf2b2520ded067d...
-
expNinja December 26th, 2013 @ 12:54 PM
(from [1cf7a23267eef168d1d6ba2dd6039e754da206d8]) Restricts 'Approve' action to 'edit' perm...if you can't edit it, you can't approve it...e.g., if you can only create/edit your own items, you must not be allowed to 'approve' other items, nor should we default to allowing you to approve your own items unless granted permission. [#1058] https://github.com/exponentcms/exponent-cms/commit/1cf7a23267eef168...
-
dleffler December 30th, 2013 @ 05:04 PM
- Tag changed from “permissions, workflow” to “permissions workflow”
Will need a system setting WORKFLOW to activate and a new expRecord method supports_revisions() which sums the model property and system setting
-
dleffler December 31st, 2013 @ 06:43 PM
- Tag cleared.
The above will be easy to implement in turning on, but will be more complex to turn back off once integrated. Will require still filtering out revision_id's and approve instead of ignoring them or making assumptions.
-
-
expNinja January 5th, 2014 @ 08:01 PM
(from [17563a4bbb9a3a54036aee231ea437a63ea80593]) Adds 'editor' field to all tables with 'edited_at' field for consistency with upcoming revision support; displays 'editor' of revision in revisions list [#1058] https://github.com/exponentcms/exponent-cms/commit/17563a4bbb9a3a54...
-
dleffler March 1st, 2014 @ 01:48 AM
- Tag set to “permissions, workflow”
-
dleffler March 1st, 2014 @ 01:53 AM
- State changed from “new” to “open”
At this point, workflow is pretty robust (revisions & approval) and fully implemented within the text module (except the text module inline edit views which also still requires tinymce integration, however the feature still works, just not dynamically). The 'revisions' branch has been kept up to date w/ the 'develop' branch, so it is probably ready to re-integrate back into 'develop'.
ToDo: determine which modules should be 'workflow' enabled - requires one edit to model and updating 'edit' & showall/show views for revisions and approval.
-
-
dleffler April 13th, 2014 @ 08:22 PM
- State changed from “open” to “resolved”
'revisions' branch merged into 'develop' branch
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Bug Tracker for Exponent CMS
dleffler
expNinja