Feature request: Need to improve how/when we implement recycle bin & delete
Reported by dleffler | June 9th, 2013 @ 03:27 AM
Rollup of tickets #1032 #1033 #1034
- We currently erase all modules on a page when it's deleted (removed as a stand-alone page) though I have a local fix for this already
- We seem to send containers to the recycle bin, or at least do after implementing the above fix
- We do NOT remove module items when the module is removed from the recycle bin leaving item orphans
The recycle bin should work as such:
- when a content page is deleted from the hierarchy it is moved to the stand-alone pages
- when a stand-alone page is deleted it is removed, but the modules are sent to the recycle bin
- when a module is removed from a page it is sent to the recycle bin
- when a module is deleted from the recycle bin it and its items/content are also removed
- containers should NOT be sent to the recycle bin, but the modules they contain should.
We had tended to delete the object after sending it to the recycle bin (navigation & container) is some cases
Comments and changes to this ticket
-
dleffler June 9th, 2013 @ 03:28 AM
- Assigned user set to “dleffler”
-
dleffler June 11th, 2013 @ 06:36 PM
Note to self:
- sectionref tables stores list of ALL modules and acts as link between section & source
- sectionref->refcount = 1000 is a hard-coded module
- sectionref->refcount = 0 is a recycled bin module
- sectionref->refcount = 1 is an active module
- containers table stores list of ACTIVE modules and acts as link between container (external) and module (internal) (recycle bin modules are NOT in this table!)
Therefore to move a module to the recycle bin involves removing it from the containers table and setting its sectionref->refcount to 0...otherwise the module is untouches (expConfigs content_xxx attachments, & items entries are untouched)
And to move a recycled module out of the recycle bin changes the sectionref->refcount to 1 and adds a new containers table entry
-
expNinja June 12th, 2013 @ 06:53 PM
(from [cc8ef5e696cef1f0ab0381e6fa6cfb3f4d1cc111]) Robusts recycle bin operation which should now more consistently work...all modules from deleted pages (content pages moved to standalone first) are now placed in the recycle bin, all nested modules inside a deleted container are now placed in the recycle bin, all module items (assoc, attached, configs) are removed when a module is removed from the recycle bin, the add module dialog 'recycle bin' status is now more accurate [#1035] https://github.com/exponentcms/exponent-cms/commit/cc8ef5e696cef1f0...
-
dleffler June 12th, 2013 @ 06:57 PM
- Title changed from “Bug: Need to evaluate how/when we implement recycle bin & delete” to “Feature request: Need to improve how/when we implement recycle bin & delete”
- Assigned user cleared.
Now that the basic function of the recycle bin is MUCH more consistent, we should make it a little smart so that:
- modules without content/sources are not auto-sent to recycle bin (navigation, rssfeed, etc...) and
- the add module 'recycle bin' link is only active when there is recycle bin content for that module.
-
dleffler July 11th, 2013 @ 06:25 PM
- Assigned user set to “expNinja”
- Milestone changed from “2.2.1” to “2.2.2”
-
dleffler July 12th, 2013 @ 11:06 PM
- Assigned user cleared.
-
-
-
-
-
-
-
-
dleffler March 7th, 2015 @ 04:48 PM
Clarification on desire to not sent all modules to recycle bin:
- When deleting a module, we still retain it's config (identify) and content..therefore if a module has either, we want to keep it in the recycle bin (some navigation views have config settings)...however if a module has no content nor config, we don't want it in the recycle bin
-
-
-
-
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Bug Tracker for Exponent CMS
dleffler
expNinja